add migration and orm changes for additional lgs fields and delegate #10722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhoonbang
requested review from
a team,
jkongie,
connorwstein,
samsondav and
jmank88
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
samsondav
reviewed
Sep 20, 2023
synced offline |
jinhoonbang
commented
Sep 20, 2023
go.mod
Outdated
Comment on lines
389
to
392
| github.com/smartcontractkit/capital-markets-projects => /Users/jinbang/development/capital-markets-projects | ||
|
|
||
| github.com/smartcontractkit/capital-markets-projects/lib => /Users/jinbang/development/capital-markets-projects/lib | ||
| ) |
There was a problem hiding this comment.
waiting for corresponding capital-markets-projects repo changes to be merged
jmank88
reviewed
Sep 21, 2023
| @@ -13,6 +13,8 @@ FeedsManager = true # Default | |||
| LogPoller = false # Default | |||
| # UICSAKeys enables CSA Keys in the UI. | |||
| UICSAKeys = false # Default | |||
| # EAL is an experimental feature that exposes API endpoints for reading and writing to blockchains. | |||
| EAL = false # Default | |||
…ar-out-of-chainlink-ccip
…ar-out-of-chainlink-ccip
|
SonarQube Quality Gate
|
jinhoonbang
commented
Oct 10, 2023
|
|
||
| func legacyGasStationRoutes(app chainlink.Application, r *gin.RouterGroup) { | ||
| if app.GetConfig().Feature().EAL() { | ||
| group := r.Group("/gasstation") |
There was a problem hiding this comment.
change to /eal/v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.